Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-1692 Update background color for fyst body & remove deliberate white bg from public pages #5477

Merged

Conversation

arinchoi03
Copy link
Contributor

@arinchoi03 arinchoi03 commented Jan 29, 2025

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Realized I can put the background color on body.state_file and this should update all the pages, removed the previously scoped bg color change on .question-layout from the previous PR

How to test?

  • Should be acceptance tested across all states/flow

I tried to take screenshots but the color changes are so subtle & not worth it 😓

Copy link

Heroku app: https://gyr-review-app-5477-b4e852d95cb6.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5477 (optionally add --tail)

@arinchoi03 arinchoi03 force-pushed the FYST-1692-expand-fyst-background-color-change-to-all-pages branch from 174ace9 to 3c1bf32 Compare January 29, 2025 22:05
Copy link
Contributor

@anisharamnani anisharamnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@arinchoi03 arinchoi03 changed the title FYST-1692 Update background color for fyst body & remove deliberate white bg from privacy/sms pages FYST-1692 Update background color for fyst body & remove deliberate white bg from public pages Jan 30, 2025
@arinchoi03 arinchoi03 merged commit 35bd36c into main Jan 30, 2025
7 checks passed
@arinchoi03 arinchoi03 deleted the FYST-1692-expand-fyst-background-color-change-to-all-pages branch January 30, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants