[1508] Add Playwright for e2e testing #1535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seatuna
requested review from
sashamaryl,
mertbagt,
nesanders,
mvictor55,
timblais,
alexjball and
Mephistic
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seatuna
commented
Apr 10, 2024
tests/integrationEnvironment.ts
Outdated
Comment on lines
10
to
14
| constructor({ globalConfig, projectConfig }: ConfigTypes, context: any) { | ||
| super({ ...globalConfig, | ||
| projectConfig: { | ||
| ...projectConfig, | ||
| globals: Object.assign({}, projectConfig.globals, { |
There was a problem hiding this comment.
Jest v28 introduced a breaking change to the config object: https://jest-archive-august-2023.netlify.app/docs/28.x/upgrading-to-jest28/#test-environment
seatuna
force-pushed
the
1508_e2e-testing
branch
2 times, most recently
from
c9d26d7 to
9d867a3
Compare
seatuna
force-pushed
the
1508_e2e-testing
branch
from
9d867a3 to
9deb8af
Compare
|
Closing this PR, I redid it here: #1554 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue: #1508
This PR adds Playwright for e2e testing, a simple test for the MAPLE homepage, and resolves peer dependency issues related to testing and i18n packages. The following packages were upgraded:
jest@types/jestjest-environment-jsdomi18nnext-i18nextreact-i18nextKnown issues
Updating
jestto v29 introduced an error related to ESM imports for integration tests that touch firebase. To fix this, I had to add a custom resolver per this github thread: microsoft/accessibility-insights-web#5421 (comment)I don't have firebase set up, so I couldn't check to make sure that the tests are actually passing. I just made sure that it was in the same state as when I ran the tests in the
mainbranch. Someone with firebase set up should absolutely run the integration tests to make sure they're behaving as expected.