Adding Notification Email Data #1693
Merged
+294
−432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser record. We send digests at a user level, so it no longer makes sense to track digests individually by topic
… due to variance in digest runtimes
…have pending digests, rather than by scanning the digest topics directly
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kiminkim724
reviewed
Jan 29, 2025
kiminkim724
approved these changes
Jan 29, 2025
…gible by grouping the counts by bill
Mephistic
requested review from
sashamaryl,
mertbagt,
nesanders,
mvictor55,
timblais and
alexjball
as code owners
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the email digest data compilation needed to trigger the social layer notification email digests - I had to tweak the
nextDigestAtlogic a bit because the email template design has shifted from when the underlying mail system was originally built.Main goal here is to unblock the UI changes to the email template by making the EmailDigest data type available
This addresses #1570
Screenshots
N/A
Known issues
A few issues I'm still confirming/ironing out while this builds:
usersin firestore haveemail, but we keepemail/emailVerifiedon the user object in firebase auth, but we have some emails inprofiles- want to confirm what is source of truth here. We'll obviously only want to send emails to users with verified emails). Will add a quick backfill script to this PR once that's confirmeddeliverNotificationsfirebase function, or thefirestore-send-emailqueue extension function. The former is less likely to bite us with quirks if we need to pause, but the latter is closest to where the actual email sending happens if the need arises to shut everything down.