Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom date picker #127

Merged
merged 1 commit into from
Sep 16, 2019
Merged

add custom date picker #127

merged 1 commit into from
Sep 16, 2019

Conversation

mpettit
Copy link

@mpettit mpettit commented Sep 15, 2019

#117

Add ability to pick a custom date for reminder. In a subsequent pr, we may want to tweak button wording (adding now as "Add date") and adjust how the goal dropdown looks when reminders are more than a month away .. but just adding base functionality for now

Copy link
Contributor

@johnneed johnneed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@@ -226,6 +247,14 @@ class GoalDetails extends Component<Props> {
{/* <Text*/}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider deleting commented code

screens/goal-details/index.js Show resolved Hide resolved
@johnneed johnneed merged commit 8bbcedc into master Sep 16, 2019
@johnneed johnneed deleted the add-custom-reminder branch September 16, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants