Write data to firestore #169
Conversation
In the parseCSVFromServer() function, a new User object is created with the new data. On the updateOrCreateUseronFireStore() the new data is updated in the user record or a new user is created if that user does not exist
There was a problem hiding this comment.
This looks good @iritush. Good job figuring out how all this works together.
The only code change I would recommend is on line 218 of the index file: removing the currentUser transformation and using your data model directly. This may have downstream affects, but that's ok because (ideally) the models should be the "single source of truth", and the mobile app and the firestore database should reflect the model (not the other way around). But you're more familiar with the implementation than I am so let me know if you see any issues that I have not.
I also added a few non-functional clarifying comments and such. But this looks great. Very excited 🎉
Co-Authored-By: Micah Mutrux <micah.mutrux@gmail.com>
Co-Authored-By: Micah Mutrux <micah.mutrux@gmail.com>
Co-Authored-By: Micah Mutrux <micah.mutrux@gmail.com>
…d add a TODO item
…ateExistingUserInFirestore
…Firestore database using class methods in the ‘user’ class -Changed some function and variable names for clarity -Added comments, TODOs, and did some cleanup
…tv/cvoeo-app into write-data-to-firestore Resolving conflicts
parseCSVAndSaveToFireStore: added reading goal fields from CSV and saving to firestore. Known issue: When parsing a csv file with multiple lines that have goal data, saving to firestore is not working properly
|
In this branch: |
There was a problem hiding this comment.
Irit, thanks so much for your changes. There are some good, functional improvements since the last review, but the comments and todos are almost more important. They really helped make it clearer for me (and others, I'd imagine) to see how things work.
Feel free to merge this whenever you like 🎉 ! Also, when you merge this work, would you also create some new issues on the project board for whatever TODOs you feel are most substantial or important? Thanks for the great work Irit.
@nfloersch @doub1ejack, this is a draft still, but if you have a moment to take a look, let me know what you think so far. I ‘started over’ with this new branch to set things up for writing to the db. I found a cveoeo file with multiple lines of actual data so I used this file to get started.
I ended up using the System ID provided in these files as the uid. I think that if it is in fact a unique id that they use on their end, it might be clearer. In addition, it will simplify things for the (rare) case where a client decides to change the email address they want to use. We can totally change the uid to email if that is preferred.
Next step is to define the goals data and write it as a collection under the user document. I will use the sample data that Nick provided on Tuesday for what fields to have there