-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1200 show errors on source files with paths lengths over 255 chars #1276
Fix #1200 show errors on source files with paths lengths over 255 chars #1276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected - thanks for a great change.
Before I merge, please see my comment about formatting and then we should be good to go.
Liam
Functionally works good and looks like the code cleanup is good too! @chrjorgensen @sebjulliand This is a pretty impact change. Any chance you two can have a play with compiling code to ensure errors continue to show as they did before? I plan on writing some tests for this code in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played around with it and everything worked fine. I compiled from a local project, a remote PF and a remote streamfile (with a long name) and errors were correctly reported.
Great job; code looks good too! 😃
@angelorpa Before we can merge this, we need you to pull in the latest changes from |
…rrors-not-highligthted-for-source-files-having-long-paths
…rrors-not-highligthted-for-source-files-having-long-paths
…rrors-not-highligthted-for-source-files-having-long-paths
Hi, I did pulled the latest changes and add two cases for handler errors. Please check it, and let me know if something else is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are excellent! Thank you! This is a great addition.
Changes
Add functions to work with lines of the events file and get the real path of the source file that was compiled taking care of files with paths lengths more than 255 characters to fix #1200
Checklist
console.log
s I added