Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1200 show errors on source files with paths lengths over 255 chars #1276

Conversation

angelorpa
Copy link
Contributor

Changes

Add functions to work with lines of the events file and get the real path of the source file that was compiled taking care of files with paths lengths more than 255 characters to fix #1200

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected - thanks for a great change.

Before I merge, please see my comment about formatting and then we should be good to go.

Liam

src/api/errors/handler.ts Show resolved Hide resolved
@worksofliam worksofliam self-requested a review May 18, 2023 12:33
@worksofliam
Copy link
Contributor

Functionally works good and looks like the code cleanup is good too!

@chrjorgensen @sebjulliand This is a pretty impact change. Any chance you two can have a play with compiling code to ensure errors continue to show as they did before?

I plan on writing some tests for this code in another PR.

@sebjulliand sebjulliand self-requested a review May 23, 2023 07:35
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played around with it and everything worked fine. I compiled from a local project, a remote PF and a remote streamfile (with a long name) and errors were correctly reported.

Great job; code looks good too! 😃

@worksofliam
Copy link
Contributor

@angelorpa Before we can merge this, we need you to pull in the latest changes from master and add a test for this change into this file: https://github.com/halcyon-tech/vscode-ibmi/blob/master/src/testing/ileErrors.ts

@worksofliam worksofliam assigned angelorpa and unassigned worksofliam May 26, 2023
angelorpa and others added 4 commits May 28, 2023 13:01
…rrors-not-highligthted-for-source-files-having-long-paths
…rrors-not-highligthted-for-source-files-having-long-paths
…rrors-not-highligthted-for-source-files-having-long-paths
@angelorpa
Copy link
Contributor Author

@angelorpa Before we can merge this, we need you to pull in the latest changes from master and add a test for this change into this file: https://github.com/halcyon-tech/vscode-ibmi/blob/master/src/testing/ileErrors.ts

Hi, I did pulled the latest changes and add two cases for handler errors. Please check it, and let me know if something else is needed.

Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are excellent! Thank you! This is a great addition.

@worksofliam worksofliam merged commit dde9145 into codefori:master Jun 22, 2023
@angelorpa angelorpa deleted the fix-#1200/Compiling-Errors-not-highligthted-for-source-files-having-long-paths branch July 11, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants