Skip to content

Update streamfileResolve and downloadMemberContent APIs #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SanjulaGanepola
Copy link
Member

@SanjulaGanepola SanjulaGanepola commented Jun 9, 2023

Changes

  • Update streamfileResolve API to accept multiple names to support searching for multiple files in a set of directories
  • Update downloadMemberContent API to accept local path to which the content will be downloaded to (similar to downloadStreamfile)

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@SanjulaGanepola SanjulaGanepola changed the title Update streamfileResolve API to accept multiple names Update streamfileResolve and downloadMemberContent APIs Jun 12, 2023
@worksofliam worksofliam self-assigned this Jun 17, 2023
@worksofliam
Copy link
Contributor

@SanjulaGanepola Tests work good. Can you resolve this conflict and then should be ok to merge.

Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good. Thanks @SanjulaGanepola!

@worksofliam worksofliam merged commit 2f03e76 into codefori:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants