Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug certificate directory configurable #1377

Merged
merged 14 commits into from
Jul 8, 2023
Merged

Debug certificate directory configurable #1377

merged 14 commits into from
Jul 8, 2023

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Jun 17, 2023 •
edited
Loading

Changes

  • The debug certificate directory can be configured in the Debug Settings
  • Added additional settings UI to import debug client certificate

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam
Ability to change where debug certs live on server
2bc039e 
Signed-off-by: Liam Allan <mrliamallan@live.co.uk>
@worksofliam
Rename debug variables for clarity
6efbde1 
Signed-off-by: Liam Allan <mrliamallan@live.co.uk>
@worksofliam
Require restart if debug cert path changes
ef60212 
Signed-off-by: Liam Allan <mrliamallan@live.co.uk>
@worksofliam
Ability to open to a specific tab
4a3c739 
Signed-off-by: Liam Allan <mrliamallan@live.co.uk>
@worksofliam
New check if debug service is running if no certs are found
8a6ff1f 
Signed-off-by: Liam Allan <mrliamallan@live.co.uk>
@worksofliam
Change settings openings to use specific tab
f563837 
Signed-off-by: Liam Allan <mrliamallan@live.co.uk>
@worksofliam
Merge branch 'master' into feature/debug_certs_config
82bd126 
Signed-off-by: Liam Allan <mrliamallan@live.co.uk>
@worksofliam worksofliam self-assigned this Jun 17, 2023
@worksofliam worksofliam marked this pull request as ready for review June 22, 2023 14:37
@worksofliam worksofliam removed their assignment Jun 22, 2023
@worksofliam
Fix invalid cert config default
aa6cc36 
Signed-off-by: Liam Allan <mrliamallan@live.co.uk>
@worksofliam
Ability to import local cert from settings
2b5ca2b 
Signed-off-by: Liam Allan <mrliamallan@live.co.uk>
@worksofliam
Merge branch 'master' into feature/debug_certs_config
7a1d4e0 
Signed-off-by: Liam Allan <mrliamallan@live.co.uk>
@worksofliam
Fix bug in default tab when opening from standard UI
4842575 
Signed-off-by: Liam Allan <mrliamallan@live.co.uk>
@worksofliam
Updated text
b5d8b66 
Signed-off-by: Liam Allan <mrliamallan@live.co.uk>
@worksofliam worksofliam self-assigned this Jun 28, 2023
@worksofliam worksofliam added this to the 2.0.0 release milestone Jul 8, 2023
@worksofliam
Copy link
Contributor Author

Testing myself this evening and one final code review. Fixed a bug where closing the connections tab without making a change would break. I am happy to merge.

@worksofliam worksofliam merged commit a0a63b7 into master Jul 8, 2023
@worksofliam worksofliam mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrjorgensen chrjorgensen Awaiting requested review from chrjorgensen

@sebjulliand sebjulliand Awaiting requested review from sebjulliand

Assignees

@worksofliam worksofliam

Labels
None yet
Projects
None yet
Milestone
2.0.0 release
Development

Successfully merging this pull request may close these issues.
1 participant
@worksofliam