Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug action on programs in Object Browser #1421

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Add debug action on programs in Object Browser #1421

merged 3 commits into from
Sep 1, 2023

Conversation

SanjulaGanepola
Copy link
Member

Changes

This PR adds a new Debug Program action on programs in the Object Browser. Closes #1418

image

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@SanjulaGanepola
add debug action on programs in Object Browser
30e54bd 
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola SanjulaGanepola mentioned this pull request Jul 7, 2023
Merged
@SanjulaGanepola
Copy link
Member Author

Please let me know if this change is acceptable and I can create a PR to update the docs as well

worksofliam
worksofliam reviewed Jul 20, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@edmundreinhardt
Copy link
Collaborator

@worksofliam Looking forward to this getting merged as we have a dependent PR

@worksofliam worksofliam requested a review from a team August 31, 2023 18:13
@chrjorgensen chrjorgensen self-assigned this Sep 1, 2023
chrjorgensen
chrjorgensen approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanjulaGanepola Tested and working as expected. Thanks! 🚀

@chrjorgensen chrjorgensen merged commit 08700fa into codefori:master Sep 1, 2023
@chrjorgensen
Copy link
Collaborator

@SanjulaGanepola Go ahead with a PR for updating the docs. Better also change the PTF numbers, which has been superceded:

IBM i 7.5 PTF SI80368 => SI83666
IBM i 7.4 PTF SI80364 => SI83683
IBM i 7.3 PTF SI79707 => SI83692

@SanjulaGanepola SanjulaGanepola mentioned this pull request Sep 1, 2023
Merged
@SanjulaGanepola
Copy link
Member Author

@chrjorgensen Docs PR created: codefori/docs#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrjorgensen chrjorgensen chrjorgensen approved these changes

@worksofliam worksofliam Awaiting requested review from worksofliam

Assignees

@chrjorgensen chrjorgensen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to debug programs from the Object Browser
4 participants
@SanjulaGanepola @edmundreinhardt @chrjorgensen @worksofliam