-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to create home directory #1460
Ability to create home directory #1460
Conversation
@ThePrez Thanks for the PR, great enhancement of the home directory validation. I will test this asap. 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThePrez Using ~
instead of $HOME
does not fully work in the default shell /QOpenSys/usr/bin/bsh
:
cd ~
~: No such file or directory
We can't assume the users are running bash
as shell, however much we would like that.
Also, for IBM i users not fully familiar with IFS and shells, I think it's better to have the absolute path from $HOME
in the IFS browser and not the tilde ~
. And also for us as developers when debugging issues etc.
WDYT?
Thank you. Good catch! |
7c43e66
to
1f405dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThePrez Only one question left, then we can approve and merge... 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThePrez Perfect - approved and merged.
Welcome aboard, glad to have you as a contributor! 😃
Changes
Fixes #1205
Changes:
console.log
message when creating the home directory (runs counter to PR checklist requirements)CHGUSRPRF
as I believe it to be incorrectChecklist
[ ] updated relevant documentationN/A[ ] Remove any/all(See note above in change list)console.log
s I added