Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to create home directory #1460

Merged
merged 10 commits into from
Aug 14, 2023

Conversation

ThePrez
Copy link
Collaborator

@ThePrez ThePrez commented Jul 30, 2023

Changes

Fixes #1205

Changes:

  • Check if home directory exists but is not writeable
  • Allow for automatic creation of home directory (after asking the user)
  • Added a console.log message when creating the home directory (runs counter to PR checklist requirements)
  • Remove guidance about giving the user a home directory via CHGUSRPRF as I believe it to be incorrect

Checklist

  • have tested my change
  • [ ] updated relevant documentation N/A
  • [ ] Remove any/all console.logs I added (See note above in change list)
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@ThePrez ThePrez requested a review from chrjorgensen July 30, 2023 17:03
@chrjorgensen chrjorgensen self-assigned this Jul 30, 2023
@chrjorgensen chrjorgensen added the enhancement New feature or request label Jul 30, 2023
@chrjorgensen
Copy link
Collaborator

@ThePrez Thanks for the PR, great enhancement of the home directory validation. I will test this asap. 😃

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThePrez Using ~ instead of $HOME does not fully work in the default shell /QOpenSys/usr/bin/bsh:

cd ~
~: No such file or directory

We can't assume the users are running bash as shell, however much we would like that.
Also, for IBM i users not fully familiar with IFS and shells, I think it's better to have the absolute path from $HOME in the IFS browser and not the tilde ~. And also for us as developers when debugging issues etc.

WDYT?

@ThePrez
Copy link
Collaborator Author

ThePrez commented Jul 31, 2023

@ThePrez Using ~ instead of $HOME does not fully work in the default shell /QOpenSys/usr/bin/bsh:

cd ~
~: No such file or directory

We can't assume the users are running bash as shell, however much we would like that.
Also, for IBM i users not fully familiar with IFS and shells, I think it's better to have the absolute path from $HOME in the IFS browser and not the tilde ~. And also for us as developers when debugging issues etc.

WDYT?

Thank you. Good catch!
I will revert 7c43e66

@ThePrez ThePrez force-pushed the feature/homedironconnect branch from 7c43e66 to 1f405dc Compare July 31, 2023 14:01
@ThePrez ThePrez requested a review from chrjorgensen July 31, 2023 14:02
src/api/IBMi.ts Outdated Show resolved Hide resolved
@ThePrez ThePrez requested a review from chrjorgensen August 1, 2023 01:27
src/api/IBMi.ts Show resolved Hide resolved
@ThePrez ThePrez requested a review from chrjorgensen August 1, 2023 14:17
src/api/IBMi.ts Show resolved Hide resolved
src/api/IBMi.ts Show resolved Hide resolved
@chrjorgensen chrjorgensen mentioned this pull request Aug 9, 2023
2 tasks
src/api/IBMi.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThePrez Only one question left, then we can approve and merge... 😃

@worksofliam worksofliam added this to the 2.1.0 milestone Aug 11, 2023
@chrjorgensen chrjorgensen assigned ThePrez and unassigned chrjorgensen Aug 11, 2023
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThePrez Perfect - approved and merged.
Welcome aboard, glad to have you as a contributor! 😃

@chrjorgensen chrjorgensen merged commit e0e4287 into codefori:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better information or automation relating to home directory
3 participants