Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning message if you're *ALLOBJ #1479

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

ThePrez
Copy link
Collaborator

@ThePrez ThePrez commented Aug 9, 2023

Changes

People shouldn't do development with *ALLOBJ-type authority

Checklist

  • have tested my change
  • updated relevant documentation (n/a)
  • Remove any/all console.logs I added
  • eslint is not complaining
  • for feature PRs: PR only includes one feature enhancement.

@ThePrez ThePrez requested a review from chrjorgensen August 9, 2023 19:02
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThePrez Nice addition - even though I will be met by this message everytime I connect, since I'm the admin... 😆 (but this may make me change my setup and routines 😃)

Could you add a progress message for this and put the code after it? Since this has nothing to do with temp library config...

@chrjorgensen chrjorgensen added the enhancement New feature or request label Aug 10, 2023
src/api/IBMi.ts Outdated Show resolved Hide resolved
@worksofliam worksofliam added this to the 2.1.0 milestone Aug 11, 2023
@ThePrez
Copy link
Collaborator Author

ThePrez commented Aug 13, 2023

Tweaked surrounding logic at e6a1a5c

@chrjorgensen chrjorgensen self-requested a review August 14, 2023 08:51
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThePrez Approved and merged - thanks!

@chrjorgensen chrjorgensen dismissed worksofliam’s stale review August 14, 2023 08:58

Requested change is in 517d63c

@chrjorgensen chrjorgensen merged commit a3382ef into codefori:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants