Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for attempting to use a locale that is not defined #1499

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Fix for attempting to use a locale that is not defined #1499

merged 1 commit into from
Aug 23, 2023

Conversation

worksofliam
Copy link
Contributor

Changes

Additional conditional check to ensure the locale exists.

Fixes #1498

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam requested review from chrjorgensen and a team August 23, 2023 14:43
sebjulliand
sebjulliand approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebjulliand sebjulliand merged commit ae88dc9 into master Aug 23, 2023
@sebjulliand sebjulliand deleted the fix/locale_no_exist branch August 23, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

@chrjorgensen chrjorgensen Awaiting requested review from chrjorgensen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'name')
2 participants
@worksofliam @sebjulliand