Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to clear error on line edit #1507

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

worksofliam
Copy link
Contributor

Changes

Since it wasn't possible to move diagnostics as documents change, we've added a piece of code that will clear the error if the line it is on edited. This suggested came from a user.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam requested review from sebjulliand and chrjorgensen and removed request for sebjulliand October 16, 2023 15:38
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worksofliam Working as expected - nice change! 😃

@chrjorgensen chrjorgensen merged commit b2c988e into master Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants