Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ProviderResult import in typings #1548

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fixed ProviderResult import in typings #1548

merged 1 commit into from
Sep 19, 2023

Conversation

sebjulliand
Copy link
Collaborator

Changes

The ProviderResult type imported in the typings was imported from the Git API types instead of vscode's.

Checklist

  • have tested my change

@sebjulliand sebjulliand self-assigned this Sep 19, 2023
worksofliam
worksofliam approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@worksofliam worksofliam merged commit 7a9b4a5 into master Sep 19, 2023
@sebjulliand sebjulliand deleted the fix/wrongTypings branch September 19, 2023 15:39
@sebjulliand
Copy link
Collaborator Author

It blew up to my face this afternoon 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worksofliam worksofliam worksofliam approved these changes

Assignees

@sebjulliand sebjulliand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebjulliand @worksofliam