Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment variable to manage debug settings #1595

Merged
merged 7 commits into from
Oct 28, 2023
Merged

Environment variable to manage debug settings #1595

merged 7 commits into from
Oct 28, 2023

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Oct 17, 2023 •
edited
Loading

Changes

  • Adds DEBUG_MANAGED variable, and when true will:
    1. Hide the certificate UI in the connection settings
    2. Control secure mode based on if DEBUG_CA_PATH environment variable is set
    3. Hide 'setup debug' commands
    4. Hide debug setup walkthrough (PR in a separate repo)

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

This was linked to issues Oct 17, 2023
DEBUG_MANAGED environment variable #1594
Closed
Debug walking disable context value #1591
Closed
william-xiang
william-xiang suggested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@william-xiang william-xiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the action on connected event at line 346 in src/api/debug/index.ts should also be changed. It does not need to check the remove cert or set the local cert for the managed environment.

package.json Show resolved Hide resolved
william-xiang
william-xiang approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@william-xiang william-xiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you.

@worksofliam
Copy link
Contributor Author

@codefori/core Any chance I can get some additional testing? Next step to ensure the debugger continues to work as normal. It is working good for me, but extra coverage never hurts.

@worksofliam worksofliam added the build Build will be available inside PR. label Oct 18, 2023
@github-actions
Copy link
Contributor

👋 A new build is available for this PR based on ff7b966.

sebjulliand
sebjulliand approved these changes Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and it works as expected.
Options are hidden when the env var is set to true. Everything works fine here.

@worksofliam worksofliam merged commit 3ef2d44 into master Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

@william-xiang william-xiang william-xiang approved these changes

@chrjorgensen chrjorgensen Awaiting requested review from chrjorgensen

@Wright4i Wright4i Awaiting requested review from Wright4i

Assignees
No one assigned
Labels
build Build will be available inside PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEBUG_MANAGED environment variable Debug walking disable context value
3 participants
@worksofliam @sebjulliand @william-xiang