Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted IFS browser to TypeScript #1611

Merged
merged 29 commits into from
Nov 18, 2023
Merged

Converted IFS browser to TypeScript #1611

merged 29 commits into from
Nov 18, 2023

Conversation

sebjulliand
Copy link
Collaborator

Changes

This PR converts the IFS Browser to TypeScript.

Also:

  • Code has been refactored a bit
  • Some commands are hidden from the command palette if not intended to be called from there
  • IFS Shortcuts and Directory now have an icon
  • A French translation has been fixed

Checklist

  • have tested my change
  • for feature PRs: PR only includes one feature enhancement.

@sebjulliand
Fixed FR upload translation
3fbd262 
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
IFSFile::modified is always a Date
56d030f 
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
Hide commands from palette
3006476 
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
Converted IFS browser to TypeScript
3c19861 
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
Fixed FR typo
02dd283 
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand added the enhancement New feature or request label Oct 24, 2023
@sebjulliand sebjulliand requested a review from a team October 24, 2023 14:12
@sebjulliand sebjulliand self-assigned this Oct 24, 2023
@sebjulliand sebjulliand changed the title Converted IFS browser Converted IFS browser to TypeScript Oct 24, 2023
@sebjulliand
Replaced paseCommand with sendCommand
a1f5548 
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand mentioned this pull request Nov 1, 2023
Merged
2 tasks
@worksofliam
Copy link
Contributor

@sebjulliand This is so fab! It's even less lines of code - I am going to run with this build for a few days and see how it goes.. will post back if I find any issues.

@worksofliam worksofliam self-assigned this Nov 6, 2023
@worksofliam worksofliam added this to the 2.5.0 release milestone Nov 17, 2023
@sebjulliand sebjulliand mentioned this pull request Nov 17, 2023
Closed
worksofliam
worksofliam requested changes Nov 18, 2023
View reviewed changes
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most functionality is looking good, other than the little issue that I can't open files. See my comments regarding a type issue.

Other things that are working:

  • Download
  • Rename / Move
  • Search with valid results
  • Delete object
  • Open in terminal

src/views/ifsBrowser.ts
super({ name: shortcut, path: shortcut, type: "directory" })

this.contextValue = "shortcut";
this.iconPath = new vscode.ThemeIcon("folder-library");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I love this new icon!

src/views/ifsBrowser.ts
constructor(file: IFSFile, parent?: IFSDirectoryItem) {
super(file, { state: vscode.TreeItemCollapsibleState.Collapsed, parent })

this.contextValue = "directory";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directory icon.. so simple yet so nice.

src/views/ifsBrowser.ts
this.iconPath = vscode.ThemeIcon.Folder;
}

async getChildren(): Promise<BrowserItem[]> {
Copy link
Contributor

@worksofliam worksofliam Nov 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the logic to fetch subitems to this right class is a nice touch.

src/views/ifsBrowser.ts Outdated Show resolved Hide resolved
@worksofliam worksofliam removed their assignment Nov 18, 2023
@sebjulliand
Fixed "Open Stream file" action
90352fb 
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
Copy link
Collaborator Author

@worksofliam Thanks for the nice feedback mate!
I fixed the call to open editable. It works fine now!

worksofliam
worksofliam approved these changes Nov 18, 2023
View reviewed changes
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Now we're looking excellent!!

I also testing some additional work to make sure shortcuts are working as expected.

Go ahead and merge whenever you're ready!

@sebjulliand
Copy link
Collaborator Author

@sebjulliand Now we're looking excellent!!

I also testing some additional work to make sure shortcuts are working as expected.

Go ahead and merge whenever you're ready!

Lovely! Thanks bud!

@sebjulliand sebjulliand merged commit cc745aa into master Nov 18, 2023
@sebjulliand sebjulliand deleted the typescript/ifsBrowser branch November 18, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worksofliam worksofliam worksofliam approved these changes

Assignees

@sebjulliand sebjulliand

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.5.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@sebjulliand @worksofliam