Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sort action in Object Browser #1612

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fixed sort action in Object Browser #1612

merged 1 commit into from
Oct 24, 2023

Conversation

sebjulliand
Copy link
Collaborator

Changes

Sorting in the Object Browser was not working properly because:

  • Nodes' refresh method was not calling the correct command
  • The sortBy method at member level was not bound correctly

Checklist

  • have tested my change

@sebjulliand
Fixed sort action in Object Browser
420a79c 
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Oct 24, 2023
@sebjulliand sebjulliand requested a review from a team October 24, 2023 14:33
@sebjulliand sebjulliand self-assigned this Oct 24, 2023
chrjorgensen
chrjorgensen approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Good catch! 🎣

@chrjorgensen chrjorgensen merged commit e0e91ed into master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrjorgensen chrjorgensen chrjorgensen approved these changes

Assignees

@sebjulliand sebjulliand

Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebjulliand @chrjorgensen