Look for member on SYSBAS if config.sourceASP is set

[sebjulliand]

Changes

This fixes an issue that can happen when downloadMemberContent is called to open a member located on *SYSBAS and an iASP is specified in the Connection Settings (i.e. config.sourceASP).

When config.sourceASP is set, downloadMemberContent will always assume the member content to fetch is located on that IASP. If the member is actually on *SYSBAS, it can never be read.

This PR makes downloadMemberContent tries twice to fetch a member if an IASP is set in the settings:

• First it assumes the member is on the IASP (as it used to)
• If not found, it will try again without the IASP in the path
• If still not found, then it crashes

Checklist

• have tested my change

[worksofliam]

Nice. Having a look at the code, it looks like it's falling back to *SYSBAS if it's not in the ASP the user defines first, so it looks in this order:

1. If the user has an ASP defined, look there. Return it if found.
2. Otherwise, look in *SYSBAS (undefined in the asp variable).

Just about to give it a test.

[worksofliam]

Looks like it worked for reading files.. but not saving!

I don't have any ASPs to test with, but it did allow me to test with an invalid name to test the fall back:

In the output:

.: system "CPYTOSTMF FROMMBR('/boop/QSYS.lib/LIAMA.lib/QRPGLESRC.file/JP.mbr') TOSTMF('/tmp/vscodetemp-O_3z3bFCsE') STMFOPT(*REPLACE) STMFCCSID(1208) DBFCCSID(*FILE)"
{
    "code": 255,
    "signal": null,
    "stdout": "",
    "stderr": "CPFA0A9: Object not found.  Object is /boop/QSYS.lib/LIAMA.lib/QRPGLESRC.file/JP.mbr.\nCPFA097: Object not copied.  Object is /boop/QSYS.lib/LIAMA.lib/QRPGLESRC.file/JP.mbr."
}

.: system "CPYTOSTMF FROMMBR('/QSYS.lib/LIAMA.lib/QRPGLESRC.file/JP.mbr') TOSTMF('/tmp/vscodetemp-O_yubtaBfe') STMFOPT(*REPLACE) STMFCCSID(1208) DBFCCSID(*FILE)"
{
    "code": 0,
    "signal": null,
    "stdout": "CPCA082: Object copied.",
    "stderr": ""
}

When trying to save this member:

[sebjulliand]

Ugh, yeah, I forgot that there is a download AND an upload memberContent 😅
I fixed the upload too. Go for it!

[worksofliam]

Yep, now it works! This is a totally nice UX improvement.

@sebjulliand Merge when you are ready!!