Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional privateKey prop to allow private key strings #1654

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Additional privateKey prop to allow private key strings #1654

merged 1 commit into from
Nov 17, 2023

Conversation

worksofliam
Copy link
Contributor

Changes

This will allow a privateKey property on ConnectionData, which allows the content of the private key to be passed in, instead of solely just the path to the key.

No UI changes needed as this is a requirement for the connection API.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam linked an issue Nov 17, 2023 that may be closed by this pull request
New connection to allow for ssh-key content instead of path #1644
Closed
@worksofliam worksofliam added this to the 2.5.0 release milestone Nov 17, 2023
@william-xiang
Copy link
Contributor

@worksofliam Tested in Merlin, it works now with the private key content in the connection data.

@worksofliam worksofliam merged commit b6a6747 into master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0 release
Development

Successfully merging this pull request may close these issues.

New connection to allow for ssh-key content instead of path
2 participants
@worksofliam @william-xiang