Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/evfevent_reader #1715

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix/evfevent_reader #1715

merged 2 commits into from
Dec 13, 2023

Conversation

worksofliam
Copy link
Contributor

Changes

  • Solves a bug where .evfevent/ was not supported but .evfevent was
  • Removes the hard limit of reading only one .evfevent file at a time during a local action

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam added this to the 2.6.0 milestone Dec 12, 2023
edmundreinhardt
edmundreinhardt approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@edmundreinhardt edmundreinhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait for this fix! Thanks

@worksofliam worksofliam merged commit 50389b8 into master Dec 13, 2023
1 check passed
@sebjulliand sebjulliand deleted the fix/evfevent_reader branch December 13, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundreinhardt edmundreinhardt edmundreinhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@worksofliam @edmundreinhardt