Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use system names for libraries and source files in SQL #2324

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Use system names for libraries and source files in SQL #2324

merged 2 commits into from
Nov 1, 2024

Conversation

chrjorgensen
Copy link
Collaborator

Changes

This PR will fix issue #2323 (originated from discussion #2316) by changing the SQL for QSYS.LIB objects to use the system name columns instead of the SQL name columns.

How to test this PR

Examples:

  1. Create a library as a DB2 schema with a long SQL name and shorter system name:
create schema  "Testing_a_long_schema_name" for TESTSYSNAM
  1. Create a source file and member in this library:
CRTSRCPF FILE(TESTSYSNAM/SFILE) MBR(MBR)
  1. Create a filter in the Object Browser for this library.
  2. Expand the filter - with this change everything shows as expected, including tooltips.

Checklist

  • have tested my change
  • have created one or more test cases

@chrjorgensen chrjorgensen linked an issue Nov 1, 2024 that may be closed by this pull request
Not getting Source Files in Object Browser When library using a schema with a long schema name. #2323
Closed
@chrjorgensen chrjorgensen added the bug A confirmed issue when something isn't working as intended label Nov 1, 2024
@chrjorgensen chrjorgensen self-assigned this Nov 1, 2024
@chrjorgensen chrjorgensen force-pushed the fix/use-system-names-in-sql branch from 573d848 to 329f373 Compare November 1, 2024 13:24
worksofliam
worksofliam approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case is passing. Thanks for a great fix!

@chrjorgensen chrjorgensen merged commit feaeeae into codefori:master Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worksofliam worksofliam worksofliam approved these changes

@sebjulliand sebjulliand Awaiting requested review from sebjulliand

@julesyan julesyan Awaiting requested review from julesyan

Assignees

@worksofliam worksofliam

Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not getting Source Files in Object Browser When library using a schema with a long schema name.
2 participants
@chrjorgensen @worksofliam