Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build workspace watcher only once #2367

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

sebjulliand
Copy link
Collaborator

Changes

A new workspace watcher (used to track changes to be deployed) was created each time a connection was established.
This Pr makes sure only one watcher is created when the extension starts.

How to test this PR

  1. Open a local workspace
  2. Make some changes in the local files
  3. Deploy using the Changed method and check the correct number of files have been tracked

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Nov 25, 2024
@sebjulliand sebjulliand requested a review from a team November 25, 2024 22:39
@sebjulliand sebjulliand self-assigned this Nov 25, 2024
@sebjulliand sebjulliand merged commit b13e390 into master Nov 26, 2024
1 check passed
@sebjulliand sebjulliand deleted the fix/workspaceListener branch November 26, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants