Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locale order to generate seeds in JA #389

Merged
merged 1 commit into from
May 29, 2022
Merged

Conversation

takahashim
Copy link
Collaborator

@takahashim takahashim commented May 28, 2022

🎩 What? Why?

#378 の件ですが、どうもavailable_localesの順番に依存してseedのデータを作るようで、一番うしろになっているのが問題なようです。

というわけで、日本語と英語の順番を入れ替えて、日本語を先頭に移動させます。

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG upgrade notes, if required
  • If there's a new public field, add it to GraphQL API
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

seed-ja

@ayuki-joto ayuki-joto merged commit 77b8ea2 into develop May 29, 2022
@takahashim takahashim deleted the fix-locales-for-seed branch May 29, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seedに日本語が入らないところがある
2 participants