Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify aud claim cf #202

Merged
merged 14 commits into from
Feb 7, 2023
Merged

Verify aud claim cf #202

merged 14 commits into from
Feb 7, 2023

Conversation

todaywasawesome
Copy link

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

crenshaw-dev and others added 10 commits January 23, 2023 08:55
Co-Authored-By: Vladimir Pouzanov <farcaller@gmail.com>
Signed-off-by: CI <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…2170) (argoproj#12179)

* fix(settings): add CLI client ID in default OAuth2 allowed audiences

Signed-off-by: Yann Soubeyrand <yann.soubeyrand@camptocamp.com>

* fix: add CLI client IDs to default OIDC allowed audiences (argoproj#12170)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* docs

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* test

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* handle expired token properly

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Yann Soubeyrand <yann.soubeyrand@camptocamp.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Yann Soubeyrand <yann.soubeyrand@camptocamp.com>
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 44.42% // Head: 44.46% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (2e5c0d2) compared to base (545b94b).
Patch coverage: 52.03% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.5     #202      +/-   ##
===============================================
+ Coverage        44.42%   44.46%   +0.03%     
===============================================
  Files              239      240       +1     
  Lines            27896    27997     +101     
===============================================
+ Hits             12392    12448      +56     
- Misses           13820    13855      +35     
- Partials          1684     1694      +10     
Impacted Files Coverage Δ
cmd/argocd/commands/admin/settings.go 68.60% <0.00%> (ø)
util/oidc/oidc.go 57.48% <0.00%> (-0.23%) ⬇️
util/oidc/provider.go 41.66% <0.00%> (-17.16%) ⬇️
util/security/jwt.go 44.44% <44.44%> (ø)
util/session/sessionmanager.go 75.98% <70.37%> (+2.03%) ⬆️
util/settings/settings.go 52.03% <77.50%> (+0.77%) ⬆️
server/application/application_event_reporter.go 39.29% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pasha-codefresh pasha-codefresh merged commit 107ab62 into release-2.5 Feb 7, 2023
@noam-codefresh noam-codefresh deleted the verify-aud-claim-cf branch May 22, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants