-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade dependencies #866
Merged
masontikhonov
merged 8 commits into
master
from
CR-25970--security-fix-critical-and-high-in-codefresh-cli
Nov 21, 2024
Merged
build: upgrade dependencies #866
masontikhonov
merged 8 commits into
master
from
CR-25970--security-fix-critical-and-high-in-codefresh-cli
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masontikhonov
changed the title
CR-25970--security-fix-critical-and-high-in-codefresh-cli
build: upgrade dependencies
Nov 20, 2024
masontikhonov
requested review from
yaroslav-codefresh and
ziv-codefresh
as code owners
November 20, 2024 14:10
This reverts commit 71ca581.
yaroslav-codefresh
approved these changes
Nov 21, 2024
masontikhonov
deleted the
CR-25970--security-fix-critical-and-high-in-codefresh-cli
branch
November 21, 2024 10:00
masontikhonov
added a commit
that referenced
this pull request
Nov 21, 2024
This reverts commit a8af20c.
masontikhonov
added a commit
that referenced
this pull request
Nov 27, 2024
## What This PR reapplies #866 that was previously reverted in #869. It contains upgrade for multiple dependencies to address critical- and high-level CVE. In addition to #866, it: * upgrades `npm` to address [CVE-2024-21538](https://scout.docker.com/vulnerabilities/id/CVE-2024-21538?s=github&n=cross-spawn&t=npm&vr=%3E%3D7.0.0%2C%3C7.0.5&utm_source=desktop&utm_medium=ExternalLink). * Sets `NODE_NO_WARNINGS=1` env in Dockerfile ([ref](https://nodejs.org/api/cli.html#node_no_warnings1)) in order to suppress Node.js deprecation warnings, that may interrupt end-user automations, that rely on exact CLi output. * Migrates from `pkg`, which is no longer maintained, to its fork `@yao-pkg/pkg`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This upgrades number of dependencies in order to address known CVE.