-
Notifications
You must be signed in to change notification settings - Fork 164
Gitops runtime troubleshooting #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
<!--- ##### Ensure token formatting | ||
Make sure the token is pasted without leading or trailing spaces. --> | ||
|
||
##### Skip validation for fine-grained GitHub tokens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from runtime >0.18.0
(app-proxy >1.3356.0
) we support fine-grained tokens without the need to use the skipGitPermissionValidation
value to true
.
i think we can remove this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am leaving it and adding if runtime version is less than above
Updated skip token validation section with runtime version for this requirement
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
…odefresh-io/docs.codefresh.io into gitops-runtime-troubleshooting
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
Added where and when context to errors
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-runtime-troubleshooting/docs/" |
No description provided.