-
Notifications
You must be signed in to change notification settings - Fork 8
feat(gitops-operator): add debug flag #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scme0
reviewed
Nov 4, 2025
charts/gitops-runtime/templates/_components/gitops-operator/_deployment.yaml
Show resolved
Hide resolved
scme0
reviewed
Nov 4, 2025
charts/gitops-runtime/templates/_components/gitops-operator/_default_values.tpl
Outdated
Show resolved
Hide resolved
scme0
reviewed
Nov 4, 2025
charts/gitops-runtime/templates/_components/gitops-operator/_deployment.yaml
Outdated
Show resolved
Hide resolved
scme0
approved these changes
Nov 5, 2025
Contributor
scme0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed this seems to be working well locally
Contributor
|
/e2e |
ilia-medvedev-codefresh
approved these changes
Nov 5, 2025
Contributor
|
/e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding a debug flag so that the gitops operator can be "disabled" when a developer want's to run a debug version of the operator in a cluster with mirrord. The issue this solves is that when you run the operator via mirrord, the existing operator container still receives cluster resource events so the two operators compete and race each other leading to weird/wrong behaviour. Currently the operator cannot be scaled horizontally.
We need the pod to run so that mirrord can intercept traffic to/from it for the debug instance of the operator.
Why
The mirrord solution for this is to install their operator into the cluster and use their paid version. It doesn't seem worth it for just one component so we came up with this solution.
Notes