Azure key vault saas 4694 #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongio
approved these changes
Dec 10, 2019
dustinvanbuskirk
requested changes
Dec 10, 2019
There was a problem hiding this comment.
Since we are going to deprecate the associated repository that is linked to the Docker image being used.
This build is required to update the Docker image with the python scripting and Dockerfile changes.
I want to see that we have a Codefresh build connected to changes on master branch of this folder to build the Dockerfile and push codefreshplugins/cfstep-azure-key-vault with a new tag matching the version of the step to that Docker image.
|
@dustinvanbuskirk See the Build_Step_Images/azure-key-vault-plugin build in the codefresh-plugins account. |
dustinvanbuskirk
approved these changes
Dec 11, 2019
|
I'll archive the other repository when you have this merged to master. |
alex-codefresh
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
KeyVaultClientis not available more - azure-sdk-for-python/issues/8591, the newSecretClientis used instead.To login to the vault, the environment variables 'AZURE_CLIENT_ID', 'AZURE_CLIENT_SECRET' and 'AZURE_TENANT_ID' should be set.