Merge pull request #338 from m-maillot/fix/html-semantic-errors

fix: W3C html semantic errors
codegouvfr · Nov 6, 2024 · fa691c6 · fa691c6
2 parents 1d89351 + be282fb
commit fa691c6
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/src/Header/Header.tsx b/src/Header/Header.tsx
@@ -375,7 +375,7 @@ export const Header = memo(
                                                     )}
                                                 >
                                                     <button
-                                                        id={`${id}-search-button`}
+                                                        id={`${id}-search-close-button`}
                                                         className={fr.cx("fr-btn--close", "fr-btn")}
                                                         aria-controls={searchModalId}
                                                         title={t("close")}

diff --git a/src/Input.tsx b/src/Input.tsx
@@ -160,7 +160,7 @@ export const Input = memo(
                                 classes.nativeInputOrTextArea
                             )}
                             disabled={disabled || undefined}
-                            aria-describedby={messageId}
+                            aria-describedby={state !== "default" ? messageId : undefined}
                             type={textArea ? undefined : nativeInputProps?.type ?? "text"}
                             id={inputId}
                         />

diff --git a/src/Modal/Modal.tsx b/src/Modal/Modal.tsx
@@ -62,7 +62,6 @@ const Modal = memo(
         return (
             <dialog
                 aria-labelledby={titleId}
-                role="dialog"
                 id={id}
                 className={cx(fr.cx("fr-modal", topAnchor && "fr-modal--top"), className)}
                 style={style}