Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer operatorLogo & next/image #111

Open
sylvainlg opened this issue Apr 18, 2023 · 3 comments
Open

Footer operatorLogo & next/image #111

sylvainlg opened this issue Apr 18, 2023 · 3 comments

Comments

@sylvainlg
Copy link
Contributor

Hi,
I'm new using the package and i want to know how to use the operator Logo.image with Next JS & next/image features.
Do you made it already ?
Thanks
@enguerranws
Copy link
Collaborator

Hi!

Right now, I think you can't use a next/image component as a value of operatorLogo prop (https://github.com/codegouvfr/react-dsfr/blob/main/src/Footer.tsx#L28).

We could consider adjusting this prop to accept its current type and a ReactNode (or something more restrictive)?

@garronej
Copy link
Collaborator

@sylvainlg would you link me the relevent next.js doc

@sylvainlg
Copy link
Contributor Author

Hi
The next documentation : https://nextjs.org/docs/api-reference/next/image

sbourdon13 pushed a commit to sbourdon13/react-dsfr that referenced this issue Aug 11, 2023
@garronej @gitbook-bot
GitBook: [codegouvfr#111] No subject
8b8eb1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sylvainlg @enguerranws @garronej