feat: customize localStorage key for analytics consents #302

[ocruze]

Hi! Here's my attempt to customise the localStorage key for analytics consents #302.

This PR :

• adds a localStorageKeyPrefix parameter to the createConsentManagement function
• keeps the original localStorageKeyPrefix, renamed to defaultLocalStorageKeyPrefix, as the default prefix
• adds consentLocalStorageKey (the calculated key) to the returned object of the createConsentManagement function, so that it can be used by later by the user
• updated the story

[garronej]

Thanks!
LGTM beside thoses few points.

[garronej]

Suggested change

	localStorageKeyPrefix
	localStorageKeyPrefix = defaultLocalStorageKeyPrefix

[garronej]

Suggested change

	const localStorageKey = `${
	localStorageKeyPrefix ?? defaultLocalStorageKeyPrefix
	} ${finalities.join("-")}`;
	const localStorageKey = `${localStorageKeyPrefix} ${finalities.join("-")}`;

[garronej]

Suggested change

	FooterPersonalDataPolicyItem,
	consentLocalStorageKey: localStorageKey
	FooterPersonalDataPolicyItem,
	"consentLocalStorageKey": localStorageKey

Will you actually use this value?
Because if there is no identified usecase for it no need to increace the API surface.

[garronej]

Yeah so I see, you exported it for Storybook.
The storybook needs shouldn't affect the API.

[ocruze]

Ok after thinking, the use case we have won't be covered by just returning the computed key. So, I removed it from the return.

[garronej]

I'd like to keep this undocumented.
It's a niche thing that is relevent in your usecase but for most app it won't be.
Pepole don't read documentation. If they see the doc is a little bit too long they'd rather implement their own solution.
So let's keep only the essential info.

[ocruze]

Ok, I removed all mentions in the documentation.

[garronej]

Thanks!