-
Notifications
You must be signed in to change notification settings - Fork 76
feat: Ajout des pictogrammes du DSFR đź’Ž #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is briliant thanks! |
Thanks again for the time and energy you put into this, it’s really appreciated. I had to revert the changes as the dependency updates caused some issues in downstream projects, especially with Storybook. React-related dependencies are a bit tricky in this library because of how it's used across very different stacks, and we try to avoid touching them unless strictly necessary. Would you mind opening a new PR with just the relevant updates (excluding the dependency changes)? That would be super helpful. Thanks again! |
Bonjour,
Dans le cadre du développement de la Startup d'État Datalma, nous utilisons ce module pour intégrer facilement le DSFR dans nos environnements React. Il est très bien conçu ; cependant, nous avons constaté l'absence des pictogrammes, que nous avons dû implémenter nous-mêmes pour répondre à nos besoins.
Ayant déjà réalisé ce travail, j’ai pensé qu’il serait pertinent de proposer une implémentation, inspirée de celle de Mui, afin de compléter ce module.
Cette PR contient :
Les pictogrammes sont accessibles via l'import du dossier
@codegouvfr/react-dsfr/picto
Exemple :
J'espère que cela vous semblera pertinent ;)