Make email name id configurable #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@upwebdesign can you look at this PR? 🙇 🙏 |
|
@joelharkes this looks good to me. You have tested it yourself and know it works? |
|
@upwebdesign Yes we replaced it with |
|
@upwebdesign can you merge it? |
|
@joelharkes done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a key cloak/aws cognito setup connected with SAML2, we had the problem that we had to change the name ID o f the application code.
We had to change the name ID. this would allow us not to keep a fork of your package, I would love to have this merged :)