Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for multiple guards. #93

Merged
merged 8 commits into from
Jun 28, 2022

Conversation

publiux
Copy link
Contributor

@publiux publiux commented Jun 26, 2022

No description provided.

@upwebdesign
Copy link
Contributor

@publiux thank you for the PR. The only concern is the light SAML dependency update. How well did you test this package with the updated lightsaml package update? Everything else looks great, thank you!

@publiux
Copy link
Contributor Author

publiux commented Jun 28, 2022

@publiux thank you for the PR. The only concern is the light SAML dependency update. How well did you test this package with the updated lightsaml package update? Everything else looks great, thank you!

I tested it with both and it works fine on my end. For safety's sake, we can leave it on the original dependency and it will work fine. The important part of this PR is the ability to pass the guard(s).

@upwebdesign upwebdesign merged commit 3943cf8 into codegreencreative:master Jun 28, 2022
@upwebdesign upwebdesign mentioned this pull request Jun 28, 2022
@upwebdesign
Copy link
Contributor

Closes #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants