Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modello:java mojo javaSource parameter default assumes compiler source is used #194

Closed
cstamas opened this issue Mar 11, 2022 · 1 comment · Fixed by #405
Closed

modello:java mojo javaSource parameter default assumes compiler source is used #194

cstamas opened this issue Mar 11, 2022 · 1 comment · Fixed by #405
Assignees
@slawekjaranowski
Labels
bug

Comments

@cstamas
Copy link
Member

cstamas commented Mar 11, 2022

While with Java 9+ this is not must, as there is release flag that replaces source/target. It may need a bit more sophisticated way to figure out should it generate generics or not.
@cstamas cstamas added the bug label Mar 11, 2022
@slachiewicz
Copy link
Member

maybe simply assume that we have Java 8 as minimum?

@slawekjaranowski slawekjaranowski self-assigned this Jan 1, 2024
slawekjaranowski added a commit that referenced this issue Jan 1, 2024
@slawekjaranowski
Improve discovering javaSource based on maven.compiler properties, de…
95fb81a 
…fault as 8

We can recognize based on properties:
- maven.compiler.release
- maven.compiler.source
- maven.compiler.target

fix #194
@slawekjaranowski slawekjaranowski mentioned this issue Jan 1, 2024
Merged
slawekjaranowski added a commit that referenced this issue Jan 1, 2024
@slawekjaranowski
Improve discovering javaSource based on maven.compiler properties, de…
25decf4 
…fault as 8

We can recognize based on properties:
- maven.compiler.release
- maven.compiler.source
- maven.compiler.target

fix #194
slawekjaranowski added a commit that referenced this issue Jan 1, 2024
@slawekjaranowski
Improve discovering javaSource based on maven.compiler properties, de…
adc90dc 
…fault as 8

We can recognize based on properties:
- maven.compiler.release
- maven.compiler.source
- maven.compiler.target

fix #194
slawekjaranowski added a commit that referenced this issue Jan 9, 2024
@slawekjaranowski
Improve discovering javaSource based on maven.compiler properties, de…
c07c8fd 
…fault as 8

We can recognize based on properties:
- maven.compiler.release
- maven.compiler.source
- maven.compiler.target

fix #194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slawekjaranowski slawekjaranowski

Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@cstamas @slawekjaranowski @slachiewicz