added Archiver.get/setLastModifiedDate(Date) API to force entries value #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
requested changes
Aug 14, 2019
src/main/java/org/codehaus/plexus/archiver/AbstractArchiver.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/archiver/AbstractArchiver.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/archiver/diags/DelgatingArchiver.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/archiver/diags/DelgatingArchiver.java
Outdated
Show resolved
Hide resolved
| @@ -18,6 +18,7 @@ | |||
| import java.io.File; | |||
There was a problem hiding this comment.
Side note: the class name has a typo
src/main/java/org/codehaus/plexus/archiver/diags/NoOpArchiver.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/archiver/diags/TrackingArchiver.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/archiver/diags/TrackingArchiver.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/archiver/zip/AbstractZipArchiver.java
Outdated
Show resolved
Hide resolved
michael-o
approved these changes
Aug 15, 2019
| @Override | ||
| public void setLastModifiedDate( final Date lastModifiedDate ) | ||
| { | ||
| target.setLastModifiedDate(lastModifiedDate); |
this API is a step to Reproducible Builds, to get reproducible archives
This was referenced Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this API is a step to Reproducible Builds, to get reproducible archives
it is based on comments made for #49