#130 DirectoryArchiver: create parent directories for symlinks #131
Conversation
|
Hi, thanks for the contribution and sorry for the a bit late reply. Looks good to me. If you have time it would be great if you can add test case as well. |
| DirectoryArchiver archiver = new DirectoryArchiver(); | ||
| archiver.addSymlink( SYMLINK_FILE.getPath(), CURRENT_DIR.getPath() ); | ||
| archiver.setDestFile( CURRENT_DIR ); | ||
| archiver.execute(); |
There was a problem hiding this comment.
Thanks a lot for the tests. But there is already existing tests for symlinks for dir archivers (sorry forgot to mention it) - org.codehaus.plexus.archiver.SymlinkTest#testSymlinkDirArchiver. Maybe it would be better if this test is added there - to the same method or maybe a new method inside the same test class. I could help with it if you want.
There was a problem hiding this comment.
Thanks for that, I didn't see the existing tests. That simplifies things.
|
Thanks. I've re-based the branch, squashed the commit and did some small formatting change. |
|
I've expected that having the merge request number in the commit title will be enough to mark it as merged, but unfortunately didn't worked. Merged with 596257f |
No description provided.