Restore Java 8 runtime compatibility

[slachiewicz]

Java 11 is required at runtime for:

• aspectj 1.9.8+ https://github.com/eclipse/org.aspectj/blob/master/docs/dist/doc/README-199.html
• org.eclipse.jdt:ecj 3.27.0+
• com.google.errorprone:error_prone_core 2.9.0+

[olamy]

-1
it just downgrade dependencies to very old versions (and maybe with some security issues).
we are in 2023.
https://endoflife.date/java
and BTW eclipse ecj or errorprone users are aware of this.

[slachiewicz]

This is to fix #247 where we upgraded Java for part of artefacts in patch versions.
My goal is to restore compatibility, release one version and then upgrade project to Java 11 in next minor version

[olamy]

This is to fix #237 where we upgraded Java for part of artefacts in patch versions. My goal is to restore compatibility, release one version and then upgrade project to Java 11 in next minor version

it's a test artifact so I do not understand the problem..... the most important compiler (e.g javac) is still compatible with 8 at runtime!
here you are talking about test dependency. I don't really understand what is the problem?
we are still releasing javac compiler which is java 8 compatible at runtime according to those lines

plexus-compiler/pom.xml

Line 47 in 0f53ad7

<maven.compiler.source>8</maven.compiler.source>

[slachiewicz]

Sorry #247 from issues

[olamy]

there is a probably a workaround #247 (comment) instead of downgrading so many dependencies...
because at the end of the day users will need to upgrade..... we can't keep maintaining such old version of java...

[slachiewicz]

As I mentioned above. Goal is to release one that support Java 8 and then release next versions where we explicitly say that we support only Java 11. Difference in few days only.

[olamy]

As I mentioned above. Goal is to release one that support Java 8 and then release next versions where we explicitly say that we support only Java 11. Difference in few days only.

-1 to this it doesn’t make sense because of the changes to the downstream dependencies (ecj, aspectj, errorprone)....
again there is probably a workaround for this user to try...
if you want to do so. create a release branch 1.12.1.x and work on this with a release 1.12.1.1 (but frankly that's non sense) but do not downgrade master branch it doesn’t make sense....

[slachiewicz]

Thank you for you input.