You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if the dominant root node's value is empty, set it to the recessive root node's value
which is clearly not true for blank values (i.e. length() > 0), still the dominant root node's value is overwritten by the recessive one in case it is blank(!) due to the trim logic in
As the Xpp3DomBuilder trims by default it seems like a bug to me that merging two Xpp3Dom s (usually created by Xpp3DomBuilder) should trim again before merging as this would only make a difference in case someone set xml:space="preserve" in the dominant Xpp3Dom which should IMHO take precedence.
The text was updated successfully, but these errors were encountered:
kwin
changed the title
Xpp3DomUtils.mergeIntoXpp3Dom overrides the dominantValue in case it is blank
Xpp3DomUtils.mergeIntoXpp3Dom overrides the dominant value in case it is blank
Sep 12, 2022
kwin
changed the title
Xpp3DomUtils.mergeIntoXpp3Dom overrides the dominant value in case it is blank
Xpp3DomUtils.mergeIntoXpp3Dom must not override the dominant value in case it is blank
Sep 12, 2022
michael-o
changed the title
Xpp3DomUtils.mergeIntoXpp3Dom must not override the dominant value in case it is blank
Xpp3DomUtils#mergeIntoXpp3Dom() must not override the dominant value in case it is blank
Oct 10, 2022
Despite the javadoc saying that
which is clearly not true for blank values (i.e. length() > 0), still the dominant root node's value is overwritten by the recessive one in case it is blank(!) due to the trim logic in
plexus-utils/src/main/java/org/codehaus/plexus/util/xml/Xpp3DomUtils.java
Line 285 in 3896620
As the
Xpp3DomBuilder
trims by default it seems like a bug to me that merging twoXpp3Dom
s (usually created byXpp3DomBuilder
) should trim again before merging as this would only make a difference in case someone setxml:space="preserve"
in the dominantXpp3Dom
which should IMHO take precedence.The text was updated successfully, but these errors were encountered: