Skip to content

UT improvement : Check that symlinks resources are preserved during git clone #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
axel3rd opened this issue Jun 19, 2017 · 4 comments

Comments

@axel3rd
Copy link
Contributor

axel3rd commented Jun 19, 2017

Following #20, some tests fail when symlinks resources are not preserved during git clone :

DirectoryScannerTest.testFollowSymlinks:186 null
DirectoryScannerTest.testFollowSymlinksFalse:155 expected:<9> but was:<11>

In this case, the core.symlinks option should be used:

git clone -c core.symlinks=true https://github.com/codehaus-plexus/plexus-utils.git
@axel3rd axel3rd changed the title DirectoryScanner fail with Symlinks on gitbash (mingw64 - OS Windows_NT) UT improvement : Check that symlinks resources are preserved during git clone Jun 20, 2017
@belingueres
Copy link
Contributor

You need to run the command as Admin too.
IMO a comment in the README.md should be enough. WDYT?

@axel3rd
Copy link
Contributor Author

axel3rd commented Dec 6, 2018

IMO a comment in the README.md should be enough. WDYT?

core.symlinks=true + admin mode are required. README is a way, but this is the goal of #25 with message and UT skip.

@belingueres
Copy link
Contributor

It turned out that I'd been working on a similar issue some time ago. See MSHARED-574. Please check if the applied solution for that issue fits your current needs.

@axel3rd
Copy link
Contributor Author

axel3rd commented Dec 8, 2018

Please check if the applied solution for that issue fits your current needs.

This solution seems fail the unit test on Windows 10 (if admin mode & git option not set) ; The PR discussions (maven-shared#16 & plexus-utils#25) say that a better approach is not execute this unit tests (but no fail).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants