Fixed regressions: #163 and #194 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

michael-o merged 1 commit into codehaus-plexus:master from belingueres:ISSUE-194-AND-163

Apr 16, 2022

Contributor

belingueres commented Apr 5, 2022

Regression: encoding error when parsing a ISO-8859-1 pom with Maven Resolver #163 - new case: Don't assume UTF8 as default, to allow parsing from String.
Incorrect getText() after parsing the DOCDECL section #194 - Incorrect getText() after parsing the DOCDECL section.

sonatype-lift bot reviewed

View reviewed changes

src/main/java/org/codehaus/plexus/util/xml/pull/MXParser.java Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

src/main/java/org/codehaus/plexus/util/xml/pull/MXParser.java Outdated Show resolved Hide resolved

belingueres force-pushed the ISSUE-194-AND-163 branch from 5ff5d58 to 48e6445 Compare

April 6, 2022 10:30

belingueres force-pushed the ISSUE-194-AND-163 branch from 48e6445 to 9dc1610 Compare

April 14, 2022 23:32

sonatype-lift bot reviewed

View reviewed changes

src/main/java/org/codehaus/plexus/util/xml/pull/MXParser.java Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

src/main/java/org/codehaus/plexus/util/xml/pull/MXParser.java Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

src/main/java/org/codehaus/plexus/util/xml/pull/MXParser.java Outdated Show resolved Hide resolved


          Fixed regressions:

55678b0

* codehaus-plexus#163 - new case:  Don't assume UTF8 as default, to allow parsing from String.
* codehaus-plexus#194 - Incorrect getText() after parsing the DOCDECL section.
* Added tests exercising other regressions exposed while fixing this issues.

belingueres force-pushed the ISSUE-194-AND-163 branch from 9dc1610 to 55678b0 Compare

April 15, 2022 01:03

michael-o merged commit b99f7c0 into codehaus-plexus:master

michael-o mentioned this pull request

Incorrect getText() after parsing the DOCDECL section #194

Closed

Contributor Author

belingueres commented Apr 17, 2022

@michael-o Thanks for merging this PR. Unfortunately two of the test files where commited with the wrong git core.autocrlf setting, losing the intended CRLF line endings:
src/test/resources/xml/test-entities-dos.xml
src/test/resources/xml/test-entities-in-attr-dos.xml

Member

michael-o commented Apr 17, 2022

Please provide a followup PR with gitattributes for these files.

belingueres mentioned this pull request

Fix some testing XML files checkout with incorrect eol #198

Merged

olamy added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug