Skip to content

Get rid maven-plugin-testing-harness from dependency #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Get rid maven-plugin-testing-harness from dependency #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,6 @@ limitations under the License.
</properties>

<dependencies>
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-plugin-testing-harness</artifactId>
<version>1.1</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.openjdk.jmh</groupId>
<artifactId>jmh-core</artifactId>
Expand Down
14 changes: 12 additions & 2 deletions src/test/java/org/codehaus/plexus/util/introspection/ReflectionValueExtractorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import java.util.List;
import java.util.Map;

import org.apache.maven.plugin.testing.stubs.MavenProjectStub;
import org.junit.Before;
import org.junit.Test;

Expand Down Expand Up @@ -462,6 +461,7 @@ public static class Project
private String version;

private Map<String, Artifact> artifactMap = new HashMap<String, Artifact>();
private String description;

public void setModelVersion( String modelVersion )
{
Expand Down Expand Up @@ -569,6 +569,16 @@ public Map<String, Artifact> getArtifactMap()
{
return artifactMap;
}

public void setDescription( String description )
{
this.description = description;
}

public String getDescription()
{
return description;
}
}

public static class Build
Expand Down Expand Up @@ -630,7 +640,7 @@ public Object getValue()
public void testRootPropertyRegression()
throws Exception
{
MavenProjectStub project = new MavenProjectStub();
Project project = new Project();
project.setDescription( "c:\\\\org\\apache\\test" );
Object evalued = ReflectionValueExtractor.evaluate( "description", project );
assertNotNull( evalued );
Expand Down