Refactor duplicated code in Xpp3Dom and Xpp3DomUtils #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

belingueres opened this issue Dec 18, 2019 · 1 comment

Contributor

belingueres commented Dec 18, 2019

The following methods are duplicated (or nearly identical):

mergeXpp3Dom
writeToSerializer
isEmpty
isNotEmpty

Move all the code to only one of the classes. Deprecate methods in the other class, delegating its implementation to the first class.

The text was updated successfully, but these errors were encountered:

gnodet transferred this issue from codehaus-plexus/plexus-utils

gnodet added a commit to gnodet/plexus-xml that referenced this issue


          Deprecate Xpp3DomUtils (fixes codehaus-plexus#6)

8cc90cc

Member

gnodet commented May 10, 2023

@belingueres @michael-o The PR deprecates Xpp3DomUtils in favour of Xpp3Dom which contains the needed methods.

gnodet closed this as completed in

85fe71e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment