refactor: move method calls to outside of the loop

codeigniter4 · Jan 25, 2022 · 02c4d19 · 02c4d19
1 parent 1a9ee9c
commit 02c4d19
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/system/Commands/Utilities/Routes.php b/system/Commands/Utilities/Routes.php
@@ -119,17 +119,20 @@ public function run(array $params)
 
  private function getAutoRoutes(RouteCollection $collection): array
  {
- $defaultNamespace = $collection->getDefaultNamespace();
- $finder = new ControllerFinder($defaultNamespace);
- $reader = new ControllerMethodReader($defaultNamespace);
+ $defaultNamespace = $collection->getDefaultNamespace();
+ $defaultController = $collection->getDefaultController();
+ $defaultMethod = $collection->getDefaultMethod();
+
+ $finder = new ControllerFinder($defaultNamespace);
+ $reader = new ControllerMethodReader($defaultNamespace);
 
  $tbody = [];
 
  foreach ($finder->find() as $class) {
  $output = $reader->read(
  $class,
- $collection->getDefaultController(),
- $collection->getDefaultMethod()
+ $defaultController,
+ $defaultMethod
  );
 
  foreach ($output as $item) {