Merge pull request #5637 from samsonasik/fix-phpstan-notice

Fix PHPStan notice on 1.4.4
codeigniter4 · Feb 1, 2022 · 156b24d · 156b24d
2 parents 72858ec + bf78c65
commit 156b24d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/test-phpstan.yml b/.github/workflows/test-phpstan.yml
@@ -12,6 +12,7 @@ on:
  - 'system/**'
  - composer.json
  - phpstan.neon.dist
+ - phpstan-baseline.neon.dist
  push:
  branches:
  - 'develop'
@@ -21,6 +22,7 @@ on:
  - 'system/**'
  - composer.json
  - phpstan.neon.dist
+ - phpstan-baseline.neon.dist
 
 jobs:
  build:

diff --git a/phpstan-baseline.neon.dist b/phpstan-baseline.neon.dist
@@ -640,11 +640,6 @@ parameters:
  count: 1
  path: system/Helpers/number_helper.php
 
- -
- message: "#^Variable \\$mockService in empty\\(\\) always exists and is always falsy\\.$#"
- count: 1
- path: system/Helpers/test_helper.php
-
  -
  message: "#^Variable \\$pool might not be defined\\.$#"
  count: 2
@@ -980,3 +975,8 @@ parameters:
  count: 1
  path: system/View/Parser.php
 
+ -
+ message: "#^Result of \\|\\| is always false\\.$#"
+ paths:
+ - system/Cache/CacheFactory.php
+ - system/Filters/Filters.php