Merge pull request #4608 from caswell-wc/jsonFragment_without_json

assertJsonFragment fails gracefully with invalid json
codeigniter4 · Apr 24, 2021 · 17ddb98 · 17ddb98
2 parents 92ee5c8 + 2a6ce84
commit 17ddb98
Show file tree

Hide file tree

Showing 3 changed files with 437 additions and 401 deletions.
diff --git a/system/Test/TestResponse.php b/system/Test/TestResponse.php
@@ -406,7 +406,8 @@ public function getJSON()
 	 */
 	public function assertJSONFragment(array $fragment, bool $strict = false)
 	{
-		$json    = json_decode($this->getJSON(), true);
+		$json = json_decode($this->getJSON(), true);
+		$this->assertIsArray($json, 'Response does not have valid json');
 		$patched = array_replace_recursive($json, $fragment);
 
 		if ($strict)