refactor: replace $e->getMessage() with $e in log_message()

codeigniter4 · Jun 24, 2022 · 246a24b · 246a24b
1 parent 1c5730e
commit 246a24b
Show file tree

Hide file tree

Showing 10 changed files with 11 additions and 11 deletions.
diff --git a/system/CLI/CLI.php b/system/CLI/CLI.php
@@ -673,7 +673,7 @@ public static function generateDimensions()
  // Then let the developer know of the error.
  static::$height = null;
  static::$width = null;
- log_message('error', $e->getMessage());
+ log_message('error', $e);
  }
  }
 

diff --git a/system/CLI/GeneratorTrait.php b/system/CLI/GeneratorTrait.php
@@ -234,7 +234,7 @@ protected function renderTemplate(array $data = []): string
  try {
  return view(config('Generators')->views[$this->name], $data, ['debug' => false]);
  } catch (Throwable $e) {
- log_message('error', $e->getMessage());
+ log_message('error', $e);
 
  return view("CodeIgniter\\Commands\\Generators\\Views\\{$this->template}", $data, ['debug' => false]);
  }

diff --git a/system/Cache/CacheFactory.php b/system/Cache/CacheFactory.php
@@ -73,7 +73,7 @@ public static function getHandler(Cache $config, ?string $handler = null, ?strin
  try {
  $adapter->initialize();
  } catch (CriticalError $e) {
- log_message('critical', $e->getMessage() . ' Resorting to using ' . $backup . ' handler.');
+ log_message('critical', $e . ' Resorting to using ' . $backup . ' handler.');
 
  // get the next best cache handler (or dummy if the $backup also fails)
  $adapter = self::getHandler($config, $backup, 'dummy');

diff --git a/system/Cache/Handlers/FileHandler.php b/system/Cache/Handlers/FileHandler.php
@@ -102,7 +102,7 @@ public function save(string $key, $value, int $ttl = 60)
 
  // @codeCoverageIgnoreStart
  } catch (Throwable $e) {
- log_message('debug', 'Failed to set mode on cache file: ' . $e->getMessage());
+ log_message('debug', 'Failed to set mode on cache file: ' . $e);
  // @codeCoverageIgnoreEnd
  }
 

diff --git a/system/Cookie/CookieStore.php b/system/Cookie/CookieStore.php
@@ -49,7 +49,7 @@ public static function fromCookieHeaders(array $headers, bool $raw = false)
  try {
  return Cookie::fromHeaderString($header, $raw);
  } catch (CookieException $e) {
- log_message('error', $e->getMessage());
+ log_message('error', $e);
 
  return false;
  }

diff --git a/system/Database/BaseConnection.php b/system/Database/BaseConnection.php
@@ -380,7 +380,7 @@ public function initialize()
  $this->connID = $this->connect($this->pConnect);
  } catch (Throwable $e) {
  $connectionErrors[] = sprintf('Main connection [%s]: %s', $this->DBDriver, $e->getMessage());
- log_message('error', 'Error connecting to the database: ' . $e->getMessage());
+ log_message('error', 'Error connecting to the database: ' . $e);
  }
 
  // No connection resource? Check if there is a failover else throw an error
@@ -401,7 +401,7 @@ public function initialize()
  $this->connID = $this->connect($this->pConnect);
  } catch (Throwable $e) {
  $connectionErrors[] = sprintf('Failover #%d [%s]: %s', ++$index, $this->DBDriver, $e->getMessage());
- log_message('error', 'Error connecting to the database: ' . $e->getMessage());
+ log_message('error', 'Error connecting to the database: ' . $e);
  }
 
  // If a connection is made break the foreach loop

diff --git a/system/Database/MySQLi/Connection.php b/system/Database/MySQLi/Connection.php
@@ -291,7 +291,7 @@ protected function execute(string $sql)
  try {
  return $this->connID->query($this->prepQuery($sql), $this->resultMode);
  } catch (mysqli_sql_exception $e) {
- log_message('error', $e->getMessage());
+ log_message('error', $e);
 
  if ($this->DBDebug) {
  throw $e;

diff --git a/system/Database/OCI8/Connection.php b/system/Database/OCI8/Connection.php
@@ -204,7 +204,7 @@ protected function execute(string $sql)
 
  return $result;
  } catch (ErrorException $e) {
- log_message('error', $e->getMessage());
+ log_message('error', $e);
 
  if ($this->DBDebug) {
  throw $e;

diff --git a/system/Email/Email.php b/system/Email/Email.php
@@ -1654,7 +1654,7 @@ protected function spoolEmail()
  $success = $this->{$method}();
  } catch (ErrorException $e) {
  $success = false;
- log_message('error', 'Email: ' . $method . ' throwed ' . $e->getMessage());
+ log_message('error', 'Email: ' . $method . ' throwed ' . $e);
  }
 
  if (! $success) {

diff --git a/system/HTTP/ResponseTrait.php b/system/HTTP/ResponseTrait.php
@@ -634,7 +634,7 @@ public function getCookie(?string $name = null, string $prefix = '')
 
  return $this->cookieStore->get($name, $prefix);
  } catch (CookieException $e) {
- log_message('error', $e->getMessage());
+ log_message('error', $e);
 
  return null;
  }