refactor: reverse if condition

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
codeigniter4 · Oct 23, 2022 · 54b9d3a · 54b9d3a
1 parent 585dbd0
commit 54b9d3a
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/system/CodeIgniter.php b/system/CodeIgniter.php
@@ -316,12 +316,11 @@ public function run(?RouteCollectionInterface $routes = null, bool $returnRespon
  if ($this->request instanceof IncomingRequest && strtolower($this->request->getMethod()) === 'cli') {
  $this->response->setStatusCode(405)->setBody('Method Not Allowed');
 
- if (! $this->returnResponse) {
- $this->sendResponse();
- } else {
+ if ($this->returnResponse) {
  return $this->response;
  }
 
+ $this->sendResponse();
  return;
  }
 
@@ -357,12 +356,12 @@ public function run(?RouteCollectionInterface $routes = null, bool $returnRespon
  // the exception with the $to as the message
  $this->response->redirect(base_url($e->getMessage()), 'auto', $e->getCode());
 
- if (! $this->returnResponse) {
- $this->sendResponse();
- } else {
+ if ($this->returnRespose) {
  return $this->response;
  }
 
+ $this->sendResponse();
+
  $this->callExit(EXIT_SUCCESS);
 
  return;
@@ -959,12 +958,11 @@ protected function display404errors(PageNotFoundException $e)
 
  $cacheConfig = new Cache();
  $this->gatherOutput($cacheConfig, $returned);
- if (! $this->returnResponse) {
- $this->sendResponse();
- } else {
+ if ($this->returnResponse) {
  return $this->response;
  }
 
+ $this->sendResponse();
  return;
  }