refactor: remove unneeded logic

It seems out of dated logic.
codeigniter4 · Mar 28, 2022 · 6efb121 · 6efb121
1 parent a5dbddd
commit 6efb121
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 17 deletions.
diff --git a/system/CLI/CommandRunner.php b/system/CLI/CommandRunner.php
@@ -48,11 +48,6 @@ public function __construct()
  */
  public function _remap($method, $params)
  {
- // The first param is usually empty, so scrap it.
- if (empty($params[0])) {
- array_shift($params);
- }
-
  return $this->index($params);
  }
 

diff --git a/tests/system/CLI/CommandRunnerTest.php b/tests/system/CLI/CommandRunnerTest.php
@@ -117,16 +117,4 @@ public function testBadCommand()
  // make sure the result looks like a command list
  $this->assertStringContainsString('Command "bogus" not found', CITestStreamFilter::$buffer);
  }
-
- /**
- * @TODO When the first param is empty? Use case?
- */
- public function testRemapEmptyFirstParams()
- {
- self::$runner->_remap('anyvalue', [null, 'list']);
- $result = CITestStreamFilter::$buffer;
-
- // make sure the result looks like a command list
- $this->assertStringContainsString('Lists the available commands.', $result);
- }
 }