fix: invalid DELETE query when builder uses table alias

codeigniter4 · Jul 11, 2022 · bd5ac24 · bd5ac24
1 parent dd279db
commit bd5ac24
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/system/Database/BaseBuilder.php b/system/Database/BaseBuilder.php
@@ -2363,7 +2363,7 @@ public function delete($where = '', ?int $limit = null, bool $resetData = true)
  return false; // @codeCoverageIgnore
  }
 
- $sql = $this->_delete($table);
+ $sql = $this->_delete($this->removeAlias($table));
 
  if (! empty($limit)) {
  $this->QBLimit = $limit;

diff --git a/tests/system/Database/Builder/DeleteTest.php b/tests/system/Database/Builder/DeleteTest.php
@@ -60,6 +60,20 @@ public function testGetCompiledDelete()
  $this->assertSame($expectedSQL, $sql);
  }
 
+ public function testGetCompiledDeleteWithTableAlias()
+ {
+ $builder = $this->db->table('jobs j');
+
+ $builder->where('id', 1);
+ $sql = $builder->getCompiledDelete();
+
+ $expectedSQL = <<<'EOL'
+ DELETE FROM "jobs"
+ WHERE "id" = 1
+ EOL;
+ $this->assertSame($expectedSQL, $sql);
+ }
+
  public function testGetCompiledDeleteWithLimit()
  {
  $builder = $this->db->table('jobs');